Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12401 )

Change subject: IMPALA-8064: Improve observability of wait times for runtime 
filters
......................................................................


Patch Set 3:

Totally forgot about testing, do you think it makes sense to add tests for both 
cases:
all filters arrive: arrival delay < runtime_filter_wait_time_ms
not all filters arrive: arrival delay >= runtime_filter_wait_time_ms


--
To view, visit http://gerrit.cloudera.org:8080/12401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28fd45e75c773bc01d424f5a179ae186ee9b7469
Gerrit-Change-Number: 12401
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Pooja Nilangekar <[email protected]>
Gerrit-Comment-Date: Tue, 12 Feb 2019 00:02:57 +0000
Gerrit-HasComments: No

Reply via email to