Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 )
Change subject: IMPALA-8064: Improve observability of wait times for runtime filters ...................................................................... Patch Set 3: Code-Review+2 > > Patch Set 3: > > > > Totally forgot about testing, do you think it makes sense to add > tests for both cases: > > all filters arrive: arrival delay < runtime_filter_wait_time_ms > > not all filters arrive: arrival delay >= runtime_filter_wait_time_ms > > Actually, I tried to test this change manually. For the "filters > don't arrive on time" case, I set a low wait time. But that was not > consistent, it somewhat depended on the system load and running the > same query in succession didn't help much because I think the scan > node hit the file system cache. > > Also, for all filters arrive: we may also have the case where > arrival delay >= runtime_filter_wait_time_ms since we always sleep > for SLEEP_PERIOD_MS and that may not be exactly divisible by > runtime_filter_wait_time_ms. So in reality, the only case we can > test for is: > not all filters arrive: arrival delay >= runtime_filter_wait_time_ms > I'm not sure of a way to reliably reproduce this. (I don't want to > add a flaky test which trying to fix another). > > Do you have any suggestions for adding tests? Thanks for the explanation. I dont think there is anyway of reliably producing both cases -- To view, visit http://gerrit.cloudera.org:8080/12401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28fd45e75c773bc01d424f5a179ae186ee9b7469 Gerrit-Change-Number: 12401 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 01:08:53 +0000 Gerrit-HasComments: No
