Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12401 )
Change subject: IMPALA-8064: Improve observability of wait times for runtime filters ...................................................................... IMPALA-8064: Improve observability of wait times for runtime filters This change is a diagnostic fix to improve the wait times logged for runtime filters. The filter wait time counts against the elapsed time since the filter's registration in ScanNode::Init() while the duration logged in ScanNode::WaitForRuntimeFilters() is the time spent in the function waiting for all the filters to arrive. This could be misleading as it doesn't account for the elapsed time spent between ScanNode::Init() and ScanNode::WaitForRuntimeFilters(). This change logs the maximum arrival delay for any runtime filter to arrive. >From my analysis of the logs of the failed tests, I believe the filters are actually waiting for the specified time but logging the duration incorrectly. The solution would be to increase the wait time further. This change would help validate this hypothesis. Change-Id: I28fd45e75c773bc01d424f5a179ae186ee9b7469 Reviewed-on: http://gerrit.cloudera.org:8080/12401 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/scan-node.cc M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/runtime-filter.h 3 files changed, 17 insertions(+), 12 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I28fd45e75c773bc01d424f5a179ae186ee9b7469 Gerrit-Change-Number: 12401 Gerrit-PatchSet: 5 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]>
