Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 )
Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/12428/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/12428/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2243 PS3, Line 2243: "catalog objects. Updated objects: %s, deleted objects: %s", > Nit: There is a trick you can use here. The logger has its own (clunky) for Probably doesn't matter since this is in "error" severity which is almost always enabled in most clusters. I surrounded this with if {} block since the function args seem complex. Otherwise, for simple arguments parameterized logging seems the right away. (thanks for the pointers) http://gerrit.cloudera.org:8080/#/c/12428/3/fe/src/main/java/org/apache/impala/catalog/TopicUpdateLog.java File fe/src/main/java/org/apache/impala/catalog/TopicUpdateLog.java: http://gerrit.cloudera.org:8080/#/c/12428/3/fe/src/main/java/org/apache/impala/catalog/TopicUpdateLog.java@107 PS3, Line 107: if (numTopicUpdatesToGc_ == 0) { > Here you can use the formatting trick mentioned previously. Done http://gerrit.cloudera.org:8080/#/c/12428/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/12428/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1765 PS3, Line 1765: * exceptions encountered during the create. > Nit: @return true if ... Done http://gerrit.cloudera.org:8080/#/c/12428/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1766 PS3, Line 1766: * @return true if a new table has been created with the given params, false > Might be useful to explain the response. I see a comment saying we are not Tried to clarify in the code comments. Let me know if that is not clear. http://gerrit.cloudera.org:8080/#/c/12428/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1782 PS3, Line 1782: // Tables that are not modified by this DDL are not added to the response, since > Nit: Using the log formatting can avoid the if-statement Done -- To view, visit http://gerrit.cloudera.org:8080/12428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3e914b70ba796c9b224e9dea559b8c40aa25d83 Gerrit-Change-Number: 12428 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 18:45:05 +0000 Gerrit-HasComments: Yes
