Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 )
Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response ...................................................................... Patch Set 5: Code-Review+2 (1 comment) LGTM. One very minor nit which we can skip. http://gerrit.cloudera.org:8080/#/c/12428/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/12428/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2241 PS5, Line 2241: if (LOG.isErrorEnabled()) { Nit: error should never be disabled, so no harm in doing this one in-line. We'll always pay the String.format overhead, so nothing fancy needed. -- To view, visit http://gerrit.cloudera.org:8080/12428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3e914b70ba796c9b224e9dea559b8c40aa25d83 Gerrit-Change-Number: 12428 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Wed, 13 Feb 2019 20:42:45 +0000 Gerrit-HasComments: Yes
