Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 )
Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Carrying +2. http://gerrit.cloudera.org:8080/#/c/12428/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/12428/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2241 PS5, Line 2241: LOG.error(String.format("Couldn't retrieve the covering topic version for " > Nit: error should never be disabled, so no harm in doing this one in-line. Done -- To view, visit http://gerrit.cloudera.org:8080/12428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3e914b70ba796c9b224e9dea559b8c40aa25d83 Gerrit-Change-Number: 12428 Gerrit-PatchSet: 6 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Feb 2019 21:50:33 +0000 Gerrit-HasComments: Yes