Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12285 )
Change subject: Initial support for building the toolchain in docker ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/12285/5/docker/redhat6.df File docker/redhat6.df: http://gerrit.cloudera.org:8080/#/c/12285/5/docker/redhat6.df@4 PS5, Line 4: Repo pinning seems to be missing from here. Is that intentional? http://gerrit.cloudera.org:8080/#/c/12285/5/docker/redhat6.df@6 PS5, Line 6: -y nit: seems to be redundant with "-y" also present in the docker/redhat/yum-install script file. http://gerrit.cloudera.org:8080/#/c/12285/5/in-docker.py File in-docker.py: http://gerrit.cloudera.org:8080/#/c/12285/5/in-docker.py@112 PS5, Line 112: passthrough_env Maybe add the env vars needed for publishing to the S3 bucket: - S3_BUCKET (the bucket name -- this is required, there is no default value in the scripts) - AWS_SECRET_ACCESS_KEY (the credential-bearing variables may be optional, e.g. our existing automation uses IAM roles) - AWS_ACCESS_KEY_ID - AWS_SESSION_TOKEN -- To view, visit http://gerrit.cloudera.org:8080/12285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c9bc06a3d303642eb37dea784b61e2a1f5cc6 Gerrit-Change-Number: 12285 Gerrit-PatchSet: 5 Gerrit-Owner: [email protected] <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: [email protected] <[email protected]> Gerrit-Comment-Date: Wed, 13 Feb 2019 16:42:42 +0000 Gerrit-HasComments: Yes
