[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/12285 )
Change subject: Initial support for building the toolchain in docker ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/12285/5/docker/redhat6.df File docker/redhat6.df: http://gerrit.cloudera.org:8080/#/c/12285/5/docker/redhat6.df@4 PS5, Line 4: # We need to pin our yum updates to keep old library versions. > Repo pinning seems to be missing from here. Is that intentional? Done http://gerrit.cloudera.org:8080/#/c/12285/5/docker/redhat6.df@6 PS5, Line 6: 's > nit: seems to be redundant with "-y" also present in the docker/redhat/yum- Done http://gerrit.cloudera.org:8080/#/c/12285/5/in-docker.py File in-docker.py: http://gerrit.cloudera.org:8080/#/c/12285/5/in-docker.py@112 PS5, Line 112: passthrough_env > Maybe add the env vars needed for publishing to the S3 bucket: Done -- To view, visit http://gerrit.cloudera.org:8080/12285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c9bc06a3d303642eb37dea784b61e2a1f5cc6 Gerrit-Change-Number: 12285 Gerrit-PatchSet: 6 Gerrit-Owner: [email protected] <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: [email protected] <[email protected]> Gerrit-Comment-Date: Tue, 19 Feb 2019 18:27:09 +0000 Gerrit-HasComments: Yes
