Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12285 )
Change subject: Initial support for building the toolchain in docker ...................................................................... Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/12285/6/docker/redhat6.df File docker/redhat6.df: http://gerrit.cloudera.org:8080/#/c/12285/6/docker/redhat6.df@26 PS6, Line 26: java-1.8.0-openjdk-devel > I also wonder about the JDK version selection logic: RedHat variants get 1. We don't consume the Kudu jars from the toolchain, just the client .so. The jars all come via Maven, so JDK version isn't a concern so long as it doesn't break compilation. -- To view, visit http://gerrit.cloudera.org:8080/12285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c9bc06a3d303642eb37dea784b61e2a1f5cc6 Gerrit-Change-Number: 12285 Gerrit-PatchSet: 6 Gerrit-Owner: [email protected] <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: [email protected] <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 06:17:27 +0000 Gerrit-HasComments: Yes
