Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12437 )
Change subject: IMPALA-8185: Abstract out real/mock file system operations ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12437/2/fe/src/main/java/org/apache/impala/analysis/HdfsFileSystemFacade.java File fe/src/main/java/org/apache/impala/analysis/HdfsFileSystemFacade.java: http://gerrit.cloudera.org:8080/#/c/12437/2/fe/src/main/java/org/apache/impala/analysis/HdfsFileSystemFacade.java@119 PS2, Line 119: alloc.totalNodes = Math.min(numLocalNodes + numRemoteNodes, alloc.cluster.numExecutors()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12437/2/fe/src/main/java/org/apache/impala/analysis/MockFileSystemFacade.java File fe/src/main/java/org/apache/impala/analysis/MockFileSystemFacade.java: http://gerrit.cloudera.org:8080/#/c/12437/2/fe/src/main/java/org/apache/impala/analysis/MockFileSystemFacade.java@37 PS2, Line 37: public ScanAllocation allocateScans(FeFsTable table, TScanRangeSpec scanRangeSpecs, ListMap<TNetworkAddress> hostMap) { line too long (121 > 90) http://gerrit.cloudera.org:8080/#/c/12437/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/12437/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@792 PS2, Line 792: BlockSizeReport report = analyzer.fsFacade().maxBlockSize(partition.getLocationPath()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/12437/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1114 PS2, Line 1114: if (alloc.totalNodes < alloc.cluster.numExecutors() && scanRangeSpecs_.isSetSplit_specs()) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12437/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1126 PS2, Line 1126: + " localRanges=" + alloc.numLocalRanges + " remoteRanges=" + alloc.numRemoteRanges line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a385923b64c9fb59cc6e700ee7ee14919398e6d Gerrit-Change-Number: 12437 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 21:42:18 +0000 Gerrit-HasComments: Yes
