Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12437
to look at the new patch set (#5).
Change subject: IMPALA-8185: Abstract out real/mock file system operations
......................................................................
IMPALA-8185: Abstract out real/mock file system operations
The recent addition of the test case builder introduced the idea of
running a query in "test case mode" on a system different from the on on
which the test case was created. A number of if-statements were used to
mock file system operations which depend on the file system to exist.
This patch abstracts out the mock vs. real operations into a set of
"facade" classes. The HDFS facade performs the real opeations, the
"mock" facade mocks the operations well enough to fool the planner.
Selection of the facade depends on the recently-added test case mode
query option.
Tests: Reran all tests: both those that depend on a real file system and
the test case builder tests that depend on the mock file system.
Change-Id: I1a385923b64c9fb59cc6e700ee7ee14919398e6d
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/FileSystemFacade.java
A fe/src/main/java/org/apache/impala/analysis/HdfsFileSystemFacade.java
M fe/src/main/java/org/apache/impala/analysis/HdfsUri.java
A fe/src/main/java/org/apache/impala/analysis/MockFileSystemFacade.java
M fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M
testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-nested.test
9 files changed, 376 insertions(+), 150 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/12437/5
--
To view, visit http://gerrit.cloudera.org:8080/12437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a385923b64c9fb59cc6e700ee7ee14919398e6d
Gerrit-Change-Number: 12437
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Rogers <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Paul Rogers <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
