Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12437 )
Change subject: IMPALA-8185: Abstract out real/mock file system operations ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12437/4/fe/src/main/java/org/apache/impala/analysis/FileSystemFacade.java File fe/src/main/java/org/apache/impala/analysis/FileSystemFacade.java: http://gerrit.cloudera.org:8080/#/c/12437/4/fe/src/main/java/org/apache/impala/analysis/FileSystemFacade.java@64 PS4, Line 64: ScanAllocation allocateScans(FeFsTable table, TScanRangeSpec scanRangeSpecs, > Where do we document what this does? Done http://gerrit.cloudera.org:8080/#/c/12437/4/fe/src/main/java/org/apache/impala/analysis/HdfsFileSystemFacade.java File fe/src/main/java/org/apache/impala/analysis/HdfsFileSystemFacade.java: http://gerrit.cloudera.org:8080/#/c/12437/4/fe/src/main/java/org/apache/impala/analysis/HdfsFileSystemFacade.java@102 PS4, Line 102: public ScanAllocation allocateScans(FeFsTable table, TScanRangeSpec scanRangeSpecs, > Do you know what this is used for? To be honest, I didn't work out what the method does. I just noticed that this code relies on having a real file system; something we don't have in "test case mode." The work here simply picks the code up out of HdfsScanNode and plops it down here in a way that we can mock for test cases. That said, if something looks odd, please do file a JIRA to explain the issue and perhaps we can figure out a solution as separate task. -- To view, visit http://gerrit.cloudera.org:8080/12437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a385923b64c9fb59cc6e700ee7ee14919398e6d Gerrit-Change-Number: 12437 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 21 Feb 2019 01:18:48 +0000 Gerrit-HasComments: Yes
