Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12635 )
Change subject: IMPALA-8254: Fix error when running compute stats with compression_codec set ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/12635/7/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/12635/7/be/src/service/query-options.cc@175 PS7, Line 175: template<typename ENUM_TYPE> : static bool get_thrift_enum(const string& value, > Most of this could be expressed with a template function that gets the enum Done http://gerrit.cloudera.org:8080/#/c/12635/7/be/src/service/query-options.cc@178 PS7, Line 178: es) { > The original comparison was case insensitive, which is expected for query o Oops. Done. http://gerrit.cloudera.org:8080/#/c/12635/7/be/src/service/query-options.cc@186 PS7, Line 186: > I would prefer to mention "thrift" and "enum" in the name. Done -- To view, visit http://gerrit.cloudera.org:8080/12635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cb546fbd3d2a02e0ed30d85a33a04852bed9dd2 Gerrit-Change-Number: 12635 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 01 Mar 2019 16:09:05 +0000 Gerrit-HasComments: Yes
