Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12635 )
Change subject: IMPALA-8254: Fix error when running compute stats with compression_codec set ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/12635/7/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/12635/7/be/src/service/query-options.cc@178 PS7, Line 178: es) { > Oops. Done. Can you add a few tests to verify case insensitivity? http://gerrit.cloudera.org:8080/#/c/12635/8/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/12635/8/be/src/service/query-options.cc@176 PS8, Line 176: get_thrift_enum Other functions in the class use camel case. http://gerrit.cloudera.org:8080/#/c/12635/8/be/src/service/query-options.cc@188 PS8, Line 188: get_thrift_enum_values same as line 176 http://gerrit.cloudera.org:8080/#/c/12635/8/be/src/service/query-options.cc@264 PS8, Line 264: if (!get_thrift_enum<THdfsCompression::type>(value, : _THdfsCompression_VALUES_TO_NAMES, &enum_type)) { : return Status(Substitute("Invalid compression codec: '$0'. Valid compression " : "codecs are $1.", value, : get_thrift_enum_values(_THdfsCompression_VALUES_TO_NAMES))); optional: get_thrift_enum could have a signature similar to ParseMemValue() to simplify its usage. I think it is ok to always write "Valid values are: ..." -- To view, visit http://gerrit.cloudera.org:8080/12635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cb546fbd3d2a02e0ed30d85a33a04852bed9dd2 Gerrit-Change-Number: 12635 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 01 Mar 2019 17:07:53 +0000 Gerrit-HasComments: Yes
