Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12635 )
Change subject: IMPALA-8254: Fix error when running compute stats with compression_codec set ...................................................................... Patch Set 10: Code-Review+2 (2 comments) I have one potential improvement but otherwise LGTM http://gerrit.cloudera.org:8080/#/c/12635/10/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/12635/10/be/src/service/query-options.cc@180 PS10, Line 180: for (const auto& e : enum_values_to_names) { It feels a little clunky to build the string every time and then throw it away. I don't think it *really* matters though. I'd probably factor out the string building into a separate function that returns a comma-separated list of supported enum values and have two simple loops instead of one complex loop. I'll leave it up to you whether that's better though. http://gerrit.cloudera.org:8080/#/c/12635/10/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: http://gerrit.cloudera.org:8080/#/c/12635/10/tests/metadata/test_compute_stats.py@81 PS10, Line 81: compuete compute -- To view, visit http://gerrit.cloudera.org:8080/12635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cb546fbd3d2a02e0ed30d85a33a04852bed9dd2 Gerrit-Change-Number: 12635 Gerrit-PatchSet: 10 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2019 18:26:14 +0000 Gerrit-HasComments: Yes
