Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 )
Change subject: Use `curl http://169.254.169.254/` to determine if we're running in aws ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12727/1/bin/bootstrap_system.sh@240 PS1, Line 240: curl Two remarks here: 1. curl is historically not used in these scripts, they seem to prefer wget. This is a bit ambiguous, as line 193 above installs curl for RedHat/CentOS, but not for Ubuntu variants. The base Ubuntu:16.04 Docker image definitely does not have it. 2. I'd suggest adding short timeout values to the call (whether you end up using wget or curl) to avoid stalling the script, just in case. bin/check-s3-access.sh uses something similar; it has short timeouts for a similar check. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Tue, 12 Mar 2019 16:51:23 +0000 Gerrit-HasComments: Yes
