Laszlo Gaal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12727 )

Change subject: Use `curl http://169.254.169.254/` to determine if we're 
running in aws
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12727/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/12727/1/bin/bootstrap_system.sh@240
PS1, Line 240: http://169.254.169.254
On second thought: we may need a stricter test for AWS if the goal is to decide 
if we are running in Amazon's EC2 vs some other, otherwise API-compatible 
implementation  (I'm hesitant to say "OpenStack" here because I don't know if 
OpenStack is fully API-compatible in this area). If using Amazon's NTP servers 
depends really on running inside AmazonEC2, then the existence of the metadata 
service endpoint may not be specific enough.



--
To view, visit http://gerrit.cloudera.org:8080/12727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205
Gerrit-Change-Number: 12727
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Comment-Date: Tue, 12 Mar 2019 17:11:38 +0000
Gerrit-HasComments: Yes

Reply via email to