Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 )
Change subject: IMPALA-337: Add support for POST to the webserver ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12730/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/12730/1/be/src/service/impala-http-handler.cc@237 PS1, Line 237: Value query_id(req.parsed_args.find("query_id")->second.c_str(), document->GetAllocator()); > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/12730/1/be/src/service/impala-http-handler.cc@295 PS1, Line 295: Value query_id(req.parsed_args.find("query_id")->second.c_str(), document->GetAllocator()); > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/12730/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/12730/1/be/src/util/webserver.cc@427 PS1, Line 427: req.parsed_args[ERROR_KEY] = Substitute("No URI handler for '$0'", request_info->uri); > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/12730/1/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12730/1/tests/custom_cluster/test_web_pages.py@43 PS1, Line 43: @ > flake8: E303 too many blank lines (2) Done -- To view, visit http://gerrit.cloudera.org:8080/12730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bd3ecfab53263c13a4509c278569302c9901abb Gerrit-Change-Number: 12730 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 12 Mar 2019 18:01:29 +0000 Gerrit-HasComments: Yes
