Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 )
Change subject: IMPALA-337: Add support for POST to the webserver ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12730/2/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/12730/2/be/src/util/webserver.cc@450 PS2, Line 450: // TODO(wdb): for this and other HTTP requests, we should log the > What does wdb mean here? Good point, this comment, which was copied from Kudu, doesn't make sense here. wdb is Will Berkeley, a developer on Kudu. I will remove that part of the message. http://gerrit.cloudera.org:8080/#/c/12730/2/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12730/2/tests/custom_cluster/test_web_pages.py@49 PS2, Line 49: response = requests.post("http://localhost:25000/pprof/symbol";, post_content) > Is it possible at this stage to have a test that shows a successful POST? Added a test that has a POST within the limits. However, none of our callbacks make use of the request type yet. It treats a POST just like a GET. -- To view, visit http://gerrit.cloudera.org:8080/12730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bd3ecfab53263c13a4509c278569302c9901abb Gerrit-Change-Number: 12730 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2019 21:37:11 +0000 Gerrit-HasComments: Yes
