Hello Andrew Sherman, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12730
to look at the new patch set (#4).
Change subject: IMPALA-337: Add support for POST to the webserver
......................................................................
IMPALA-337: Add support for POST to the webserver
In order to support the TraceEvent path handlers from Kudu (and
other functionality like pprof symbolization), the webserver needs
to support HTTP POST. This changes the signature for HTTP handler
callbacks to take a 'WebRequest' struct instead of a simple map of
arguments. This struct exposes the request type, POST data, and
unparsed query strings, enabling the callbacks to handle POSTs.
The struct itself is imported from Kudu's webserver code, so we can
start to share utility HTTP handlers (eg pprof or tracing) more
easily between Kudu and Impala.
The maximum length of a POST request is limited by the new
webserver_max_post_length_bytes parameter, which defaults to
1MB.
This patch was written by Todd Lipcon, based on code from Kudu.
Testing:
- Added a test for too big POSTs to custom_cluster/test_web_pages.py
- Verifies the existing core tests pass
Change-Id: I3bd3ecfab53263c13a4509c278569302c9901abb
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/rpc/rpc-trace.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/util/default-path-handlers.cc
M be/src/util/default-path-handlers.h
M be/src/util/logging-support.cc
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/pprof-path-handlers.cc
M be/src/util/thread.cc
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
M be/src/util/webserver.h
M tests/custom_cluster/test_web_pages.py
18 files changed, 251 insertions(+), 147 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/12730/4
--
To view, visit http://gerrit.cloudera.org:8080/12730
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3bd3ecfab53263c13a4509c278569302c9901abb
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
