Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12823 )

Change subject: IMPALA-8330: Impala shell config file should use flag names
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12823/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12823/2//COMMIT_MSG@23
PS2, Line 23: Q
> Honestly, I'm not a super big fan of this short naming. I think we'd unnece
It's just an additional feature that we support. I agree that users should use 
long flag instead. The problem is if we ever have a flag without long name then 
it will become the limitation of the config file.



--
To view, visit http://gerrit.cloudera.org:8080/12823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9
Gerrit-Change-Number: 12823
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 19:11:05 +0000
Gerrit-HasComments: Yes

Reply via email to