Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12823 )
Change subject: IMPALA-8330: Impala shell config file should use flag names ...................................................................... IMPALA-8330: Impala shell config file should use flag names This patch changes the file format in Impala shell config file to accept both short and long flag names instead of optparse's dest names (variable names to store flag values) because dest names are internal to Impala shell. This patch does not change the format and behavior of Impala shell config file with [impala.query_options] section. Format: [impala] flag_name=flag_value Example: [impala] ; This is long flag. query=select 1 ; This is short flag. Q=DEFAULT_FILE_FORMAT=parquet ; Flags can be repeated with , var=msg1=hello,var=msg2=world Testing: - Ran all E2E shell tests on Python 2.6 and 2.7. Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9 --- M shell/impala_shell.py M shell/option_parser.py M tests/shell/good_impalarc 3 files changed, 31 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/12823/5 -- To view, visit http://gerrit.cloudera.org:8080/12823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9 Gerrit-Change-Number: 12823 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
