Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 )
Change subject: IMPALA-8330: Impala shell config file should use flag names ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12823/2/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/12823/2/shell/option_parser.py@67 PS2, Line 67: maps short and long option name to option for a qui > also mention it maps to the dest? Done. it actually maps to option. Option can have attributes like "action", "dest", etc. http://gerrit.cloudera.org:8080/#/c/12823/2/shell/option_parser.py@275 PS2, Line 275: # The code below removes the - from the short option and -- from the long option. > I had to print these stuff locally to understand whats going on here. Add a Done http://gerrit.cloudera.org:8080/#/c/12823/2/shell/option_parser.py@277 PS2, Line 277: long_opt = option._long_opts[0][2:] if len(option._long_opts) > 0 else None > I think this part is subtle. It looks like we are updating defaults to also Done -- To view, visit http://gerrit.cloudera.org:8080/12823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9 Gerrit-Change-Number: 12823 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 22 Mar 2019 00:18:07 +0000 Gerrit-HasComments: Yes
