Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 )
Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart ...................................................................... Patch Set 1: (5 comments) We've already discussed this a bunch, but now looking at the solution in real code, I think this is good in that it solves the problem without getting into any tricky distributed systems problems. http://gerrit.cloudera.org:8080/#/c/13061/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13061/1//COMMIT_MSG@17 PS1, Line 17: Testing: Added an e2e test Just to confirm, this test failed before your change? http://gerrit.cloudera.org:8080/#/c/13061/1/be/src/statestore/statestore-subscriber.h File be/src/statestore/statestore-subscriber.h: http://gerrit.cloudera.org:8080/#/c/13061/1/be/src/statestore/statestore-subscriber.h@130 PS1, Line 130: int64 int64_t is the standard one, I guess int64 comes from some header we've pulled in. Can this be a const method, also? http://gerrit.cloudera.org:8080/#/c/13061/1/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/13061/1/tests/custom_cluster/test_restart_services.py@100 PS1, Line 100: def test_restart_statestore_query_resilience(self): If you didn't already, can you loop this test for a while, maybe with 'stress' running in the background. Just want additional assurance that it's not flaky. http://gerrit.cloudera.org:8080/#/c/13061/1/tests/custom_cluster/test_restart_services.py@117 PS1, Line 117: / > flake8: E226 missing whitespace around arithmetic operator Might be slightly cleaner to also default CANCELLATION_GRACE_PERIOD_S above http://gerrit.cloudera.org:8080/#/c/13061/1/tests/custom_cluster/test_restart_services.py@119 PS1, Line 119: # Now restart statestore and kill an impalaD while it is down, and make sure the We might need to reconcile this with IMPALA-2990, which adds another mechanism to kill queries that doesn't depend on the statestore. I don't think there's action required now, just thinking out loud. -- To view, visit http://gerrit.cloudera.org:8080/13061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30b68bd8bde4bf589d58d42d6f683afb166de959 Gerrit-Change-Number: 13061 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2019 23:57:25 +0000 Gerrit-HasComments: Yes
