Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 )
Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart ...................................................................... Patch Set 3: Code-Review+1 (1 comment) LGTM once you address Lars' comments, I can promote to +2 http://gerrit.cloudera.org:8080/#/c/13061/3/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/13061/3/tests/custom_cluster/test_restart_services.py@133 PS3, Line 133: # Now restart statestore and kill a backend after it comes back up, and make sure > Should this be a separate test? The annoying thing about custom cluster tests is that each test means a cluster restart. Could maybe be a separate function though if we want to vaoid that. -- To view, visit http://gerrit.cloudera.org:8080/13061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30b68bd8bde4bf589d58d42d6f683afb166de959 Gerrit-Change-Number: 13061 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2019 23:34:51 +0000 Gerrit-HasComments: Yes
