Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 )
Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Looks good to me once the nits are fixed. http://gerrit.cloudera.org:8080/#/c/13061/3/be/src/statestore/statestore-subscriber.h File be/src/statestore/statestore-subscriber.h: http://gerrit.cloudera.org:8080/#/c/13061/3/be/src/statestore/statestore-subscriber.h@130 PS3, Line 130: const nit: by convention we usually put the const after the signature (see above) http://gerrit.cloudera.org:8080/#/c/13061/3/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/13061/3/tests/custom_cluster/test_restart_services.py@133 PS3, Line 133: # Now restart statestore and kill a backend after it comes back up, and make sure Should this be a separate test? http://gerrit.cloudera.org:8080/#/c/13061/3/tests/custom_cluster/test_restart_services.py@135 PS3, Line 135: recived nit: typo -- To view, visit http://gerrit.cloudera.org:8080/13061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30b68bd8bde4bf589d58d42d6f683afb166de959 Gerrit-Change-Number: 13061 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 03 May 2019 16:17:24 +0000 Gerrit-HasComments: Yes
