Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 )
Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/13061/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13061/4//COMMIT_MSG@23 PS4, Line 23: of > typo Done http://gerrit.cloudera.org:8080/#/c/13061/4/be/src/statestore/statestore-subscriber.h File be/src/statestore/statestore-subscriber.h: http://gerrit.cloudera.org:8080/#/c/13061/4/be/src/statestore/statestore-subscriber.h@214 PS4, Line 214: // > nit: /// Done http://gerrit.cloudera.org:8080/#/c/13061/4/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/13061/4/be/src/statestore/statestore-subscriber.cc@196 PS4, Line 196: VLOG(1) << "No subscriber registration ID rec > Should this be set iff status.ok() ? Thanks for catching that, I initially thought that the rpc would return an error if unsuccessful and exit the method, didnt realize that is only for the RPC itself and not the result. -- To view, visit http://gerrit.cloudera.org:8080/13061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30b68bd8bde4bf589d58d42d6f683afb166de959 Gerrit-Change-Number: 13061 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 17:32:46 +0000 Gerrit-HasComments: Yes
