Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 )
Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13061/3/be/src/statestore/statestore-subscriber.h File be/src/statestore/statestore-subscriber.h: http://gerrit.cloudera.org:8080/#/c/13061/3/be/src/statestore/statestore-subscriber.h@130 PS3, Line 130: Milli > nit: by convention we usually put the const after the signature (see above) Done http://gerrit.cloudera.org:8080/#/c/13061/3/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/13061/3/tests/custom_cluster/test_restart_services.py@133 PS3, Line 133: # Now restart statestore and kill a backend after it comes back up, and make sure > The annoying thing about custom cluster tests is that each test means a clu yea i was thinking of doing the same but then there is some shared context between these tests, like using the same running query, knowing which impalad was killed before, separating them into independent functions seemed a bit unwieldy. I dont feel strongly either way, let me know what you prefer. http://gerrit.cloudera.org:8080/#/c/13061/3/tests/custom_cluster/test_restart_services.py@135 PS3, Line 135: receive > nit: typo Done -- To view, visit http://gerrit.cloudera.org:8080/13061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30b68bd8bde4bf589d58d42d6f683afb166de959 Gerrit-Change-Number: 13061 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 04 May 2019 01:20:58 +0000 Gerrit-HasComments: Yes
