Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 )
Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13251/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13251/2//COMMIT_MSG@26 PS2, Line 26: small splits on the _input_ side and thus is less likely to produce lots > nit: long lines Done http://gerrit.cloudera.org:8080/#/c/13251/2/fe/src/test/resources/hive-site.xml.py File fe/src/test/resources/hive-site.xml.py: http://gerrit.cloudera.org:8080/#/c/13251/2/fe/src/test/resources/hive-site.xml.py@95 PS2, Line 95: # gets triggered which ignores the min-size parameter. See TEZ-3310. > Is there a TODO about it? E.g. if TEZ-3310 is solved, will we need to still Done http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/README File testdata/datasets/README: http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/README@36 PS2, Line 36: supported section names supported > nit: double-wording: supported Done -- To view, visit http://gerrit.cloudera.org:8080/13251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34930dc064da3136dde4e01a011d14db6a74ecd Gerrit-Change-Number: 13251 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 07 May 2019 18:53:19 +0000 Gerrit-HasComments: Yes
