Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 )
Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/bin/generate-schema-statements.py@594 PS2, Line 594: env_key = 'IMPALA_{}_VERSION'.format(req.name.upper()) Turns out I had to do a bit of munging on this string to make it parse properly with the CDH6 version numbering scheme that includes dashes. Posting a new rev with that fix and a little refactoring. http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/functional/functional_schema_template.sql@2578 PS2, Line 2578: ---- DEPENDENT_LOAD_HIVE This actually had to be CREATE_HIVE in order to get it to create in the base 'functional' database -- To view, visit http://gerrit.cloudera.org:8080/13251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34930dc064da3136dde4e01a011d14db6a74ecd Gerrit-Change-Number: 13251 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 07 May 2019 19:28:34 +0000 Gerrit-HasComments: Yes
