Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 )
Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/13215/6/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/13215/6/common/thrift/CatalogObjects.thrift@479 PS6, Line 479: iff > It means if and only if. It will not set the list when it is null, so it is Sorry, I don't see that very often. Or I always thought that it is a typo whenever I saw it :) http://gerrit.cloudera.org:8080/#/c/13215/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/13215/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@64 PS7, Line 64: Hive 2. Hive 3? http://gerrit.cloudera.org:8080/#/c/13215/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@390 PS7, Line 390: client.getValidWriteIds(tableFullName); nit: could be used to initialize 'writeIds' in previous line. http://gerrit.cloudera.org:8080/#/c/13215/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@395 PS7, Line 395: sting nit: string http://gerrit.cloudera.org:8080/#/c/13215/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@401 PS7, Line 401: { nit: inconsistent formatting, please put it to previous line -- To view, visit http://gerrit.cloudera.org:8080/13215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6edbd64424edf0ba88af110ab8b958a1966b8b54 Gerrit-Change-Number: 13215 Gerrit-PatchSet: 7 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2019 17:02:56 +0000 Gerrit-HasComments: Yes
