Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 )
Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13306/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13306/3//COMMIT_MSG@28 PS3, Line 28: timeout : is off by default May be worth considering setting it to some large values instead of being "off". http://gerrit.cloudera.org:8080/#/c/13306/3//COMMIT_MSG@30 PS3, Line 30: We may want to consider changing : some of this behavior. We probably should consider removing states of expired sessions or Impala may risk being attacked indirectly by clients which open many sessions and never close them. Previously, a client will need to keep a connection opened to DoS Impala but with this change, it doesn't even have to. -- To view, visit http://gerrit.cloudera.org:8080/13306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4555cd9b73db5b4dde92cd4fac4f9bfa3664d78 Gerrit-Change-Number: 13306 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2019 20:14:20 +0000 Gerrit-HasComments: Yes
