Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13306 )

Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is 
closed
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13306/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13306/3//COMMIT_MSG@30
PS3, Line 30: We may want to consider changing
            : some of this behavior.
> Enabling --idle_query_timeout by default sounds like a reasonable mitigatio
It failed even if set to a very high value, IIRC even 1h.

The problem with keeping the session state around isn't the size of the session 
state itself, it's the queries dangling off it. The idle query timeout only 
cancels queries, doesn't unregister them.



--
To view, visit http://gerrit.cloudera.org:8080/13306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4555cd9b73db5b4dde92cd4fac4f9bfa3664d78
Gerrit-Change-Number: 13306
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2019 19:12:05 +0000
Gerrit-HasComments: Yes

Reply via email to