Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13306 )

Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is 
closed
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13306/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13306/3//COMMIT_MSG@30
PS3, Line 30: We may want to consider changing
            : some of this behavior.
> We had started discussing this a bit offline. Agree that we rely on the ses
Enabling --idle_query_timeout by default sounds like a reasonable mitigation 
against clients which don't fetch results. As Thomas said, the session state 
isn't that big so we can bound it at some large numbers and do LRU reclamation 
or set a reasonable large limit (e.g. 24 hrs) on how long a session will be 
maintained by default.

What was the idle_session-timeout set to when you ran tests with it enabled ?



--
To view, visit http://gerrit.cloudera.org:8080/13306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4555cd9b73db5b4dde92cd4fac4f9bfa3664d78
Gerrit-Change-Number: 13306
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Thomas Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 15 May 2019 19:03:53 +0000
Gerrit-HasComments: Yes

Reply via email to