Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 )
Change subject: IMPALA-8560: Prometheus metrics support in Impala ...................................................................... Patch Set 3: (47 comments) http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/collection-metrics.h File be/src/util/collection-metrics.h: http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/collection-metrics.h@190 PS3, Line 190: *val << name << "_stddev " << std::sqrt(boost::accumulators::variance(acc_)) << "\n"; line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/histogram-metric.h File be/src/util/histogram-metric.h: http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/histogram-metric.h@75 PS3, Line 75: std::string name, std::stringstream* value, std::stringstream* metric_kind) override { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc File be/src/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@470 PS3, Line 470: exp_val << "# HELP " << desc << "\n" << "# TYPE " << name << " " << kind << "\n" << name << " " << value + "\n"; line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@611 PS3, Line 611: "stats_metric_last 20\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@612 PS3, Line 612: "stats_metric_min 10\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@613 PS3, Line 613: "stats_metric_max 20\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@614 PS3, Line 614: "stats_metric_mean 15\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@615 PS3, Line 615: "stats_metric_stddev 5\n", tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@630 PS3, Line 630: "stats_metric_last 2230.12\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@631 PS3, Line 631: "stats_metric_min 10\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@632 PS3, Line 632: "stats_metric_max 2230.12\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@633 PS3, Line 633: "stats_metric_mean 1120.06\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@634 PS3, Line 634: "stats_metric_stddev 1110.06\n", tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@649 PS3, Line 649: "stats_metric_last 20\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@650 PS3, Line 650: "stats_metric_min 10\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@651 PS3, Line 651: "stats_metric_max 20\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@652 PS3, Line 652: "stats_metric_mean 15\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@653 PS3, Line 653: "stats_metric_stddev 5\n", tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@668 PS3, Line 668: "stats_metric_last 20\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@669 PS3, Line 669: "stats_metric_min 10\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@670 PS3, Line 670: "stats_metric_max 20\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@671 PS3, Line 671: "stats_metric_mean 15\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@672 PS3, Line 672: "stats_metric_stddev 5\n", tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@687 PS3, Line 687: "stats_metric_last 20.567\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@688 PS3, Line 688: "stats_metric_min 10.1235\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@689 PS3, Line 689: "stats_metric_max 20.567\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@690 PS3, Line 690: "stats_metric_mean 15.3452\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@691 PS3, Line 691: "stats_metric_stddev 5.22178\n", tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@706 PS3, Line 706: "stats_metric_last 20.22\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@707 PS3, Line 707: "stats_metric_min 10.22\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@708 PS3, Line 708: "stats_metric_max 20.22\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@709 PS3, Line 709: "stats_metric_mean 15.22\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@710 PS3, Line 710: "stats_metric_stddev 5\n", tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@731 PS3, Line 731: "histogram-metric{le=0.9} 9000\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@757 PS3, Line 757: "histogram-metric{le=0.9} 9000\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@783 PS3, Line 783: "histogram-metric{le=0.9} 9000\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@809 PS3, Line 809: "histogram-metric{le=0.9} 9000\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@835 PS3, Line 835: "histogram-metric{le=0.9} 9000\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@847 PS3, Line 847: "# TYPE counter1 counter\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@848 PS3, Line 848: "counter1 2048\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@849 PS3, Line 849: "# HELP description\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@850 PS3, Line 850: "# TYPE counter2 counter\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@851 PS3, Line 851: "counter2 2048\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@852 PS3, Line 852: "# HELP description\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@853 PS3, Line 853: "# TYPE child_counter counter\n" tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics-test.cc@854 PS3, Line 854: "child_counter 0\n"; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics.h File be/src/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/13345/3/be/src/util/metrics.h@175 PS3, Line 175: std::transform(metric_type.begin(), metric_type.end(), metric_type.begin(), ::tolower); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5349085a2007b568cb97f9b8130804ea64d7bb08 Gerrit-Change-Number: 13345 Gerrit-PatchSet: 3 Gerrit-Owner: Harshil <[email protected]> Gerrit-Reviewer: Harshil <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 17 May 2019 23:33:14 +0000 Gerrit-HasComments: Yes
