Harshil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13345 )

Change subject: IMPALA-8560: Prometheus metrics support in Impala
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/13345/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13345/4//COMMIT_MSG@9
PS4, Line 9: -- This change adds Prometheus text explosion format metric 
generation.
> My reading on the time units is that the prometheus convention is to conver
Done


http://gerrit.cloudera.org:8080/#/c/13345/4//COMMIT_MSG@13
PS4, Line 13:
> Did you try feeding the output of the metrics page into prometheus? I think
I have local prometheus running on same node that is ingesting this metrics and 
verified it with latest change.

Also ran it against a "./promtool" to check for any error in metrics format for 
prometheus.


http://gerrit.cloudera.org:8080/#/c/13345/4/be/src/util/metrics.h
File be/src/util/metrics.h:

http://gerrit.cloudera.org:8080/#/c/13345/4/be/src/util/metrics.h@102
PS4, Line 102:   /// name, value, human_readable, description
> Should have asked first time around, but can you include a link to https://
Done


http://gerrit.cloudera.org:8080/#/c/13345/4/be/src/util/metrics.cc
File be/src/util/metrics.cc:

http://gerrit.cloudera.org:8080/#/c/13345/4/be/src/util/metrics.cc@97
PS4, Line 97: metricsPrometheus
> metrics_prometheus to follow the same convention as other endpoints like lo
Done



--
To view, visit http://gerrit.cloudera.org:8080/13345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5349085a2007b568cb97f9b8130804ea64d7bb08
Gerrit-Change-Number: 13345
Gerrit-PatchSet: 4
Gerrit-Owner: Harshil <[email protected]>
Gerrit-Reviewer: Harshil <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 21 May 2019 23:38:05 +0000
Gerrit-HasComments: Yes

Reply via email to