Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 )
Change subject: IMPALA-8560: Prometheus metrics support in Impala ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13345/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13345/4//COMMIT_MSG@9 PS4, Line 9: -- This change adds Prometheus text explosion format metric generation. > So for 3) there is something called job_name in prometheus config, that get My reading on the time units is that the prometheus convention is to convert everything to seconds. I'm not an expert though so would appreciate you confirming that I"m not misreading things. -- To view, visit http://gerrit.cloudera.org:8080/13345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5349085a2007b568cb97f9b8130804ea64d7bb08 Gerrit-Change-Number: 13345 Gerrit-PatchSet: 4 Gerrit-Owner: Harshil <[email protected]> Gerrit-Reviewer: Harshil <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 18 May 2019 00:48:16 +0000 Gerrit-HasComments: Yes
