Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/13353 )
Change subject: IMPALA-8443: Record time spent in authorization in the runtime profile ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13353/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/13353/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@426 PS2, Line 426: (Ranger|Sentry) > If we expose access to the AuthorizationConfig stored in the AuthorizationC Adding the current provider sounds good to me, it would be one less thing to check during troubleshooting and would look better. Another solution I was thinking could be to move the analyzeAndAuthorize to Frontend and get the AuthorizationConfig from the AuthorizationFactory. This would clean the AnalysisContext from the authorization part, however the Frontend would grow slightly bigger again. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/13353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb85e57fcc75d41f3eb2911e6d375e0da6f82ae Gerrit-Change-Number: 13353 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 16:47:59 +0000 Gerrit-HasComments: Yes
