Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/13353 )
Change subject: IMPALA-8443: Record time spent in authorization in the runtime profile ...................................................................... Patch Set 3: Hi Fredy, thanks for keeping an eye on this. Yes, I am working on it, I just got interrupted in the past couple of weeks. I was moving the timeline into the AuthorizationContext here: https://github.com/apache/impala/blob/ab908d54c22861967f693428ec7d9f6d7008607f/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java#L424 However, in some cases a new AuthorizationContext is created during AuthorizationChecker 'hasAccess' call. https://github.com/apache/impala/blob/ab908d54c22861967f693428ec7d9f6d7008607f/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java#L66 I am working on to untangle this part at the moment, will get back to you with a new patch by EOB Monday. -- To view, visit http://gerrit.cloudera.org:8080/13353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb85e57fcc75d41f3eb2911e6d375e0da6f82ae Gerrit-Change-Number: 13353 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 09:51:23 +0000 Gerrit-HasComments: No
