Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/13353 )
Change subject: IMPALA-8443: Record time spent in authorization in the runtime profile ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13353/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/13353/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@426 PS2, Line 426: (Ranger|Sentry) > Yeah in my CR: https://gerrit.cloudera.org/c/13309/6/fe/src/main/java/org/a Thanks guys for looking into it. Austin, a new class would be ideal, but I could not find anything else to refactor with the analyzeAndAuthorize and it seems it would have too many boilerplate parts alone. The best option as you mentioned exposing the AuthorizationConfig. Fredy, I assume we should pass the timeline to the AuthorizationChecker and it could be called next to the logging. The EventSequence should be modified that when it marks an event it returns the timestamp as well. So, I should wait for https://gerrit.cloudera.org/#/c/13309/ to be submitted for now. Is my understanding correct? -- To view, visit http://gerrit.cloudera.org:8080/13353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb85e57fcc75d41f3eb2911e6d375e0da6f82ae Gerrit-Change-Number: 13353 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 09:17:15 +0000 Gerrit-HasComments: Yes
