Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 )
Change subject: acid: Filter unwanted files based on ACID state. ...................................................................... Patch Set 12: (3 comments) Gone through the first half. Will continue tomorrow. http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java@48 PS12, Line 48: private static final Pattern BASE_PATTERN = Pattern.compile("base_(\\d+)(/.*)?"); : private static final Pattern DELTA_PATTERN = : Pattern.compile("delta_(\\d+)_(\\d+)(_\\d+)?(/.*)?"); nit: maybe you could use "name-capturing groups" in the regex to make it more verbose, e.g. "delta_(?<minWriteId>\\d+)..." http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java@151 PS12, Line 151: statementGroup.substring(1) DELTA_PATTERN allows strings like 'delta_1_2_asdf', i.e. we have the trailing '(/.*)?' group, but no statement id. In that case it will throw an exception. Name-capturing groups can also help here. http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java@170 PS12, Line 170: >= Shouldn't this be '=='? Can it happen that baseNum is greater than max base id? -- To view, visit http://gerrit.cloudera.org:8080/13334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0aeb36e10c827ead59ed7f67e731199394fe8e Gerrit-Change-Number: 13334 Gerrit-PatchSet: 12 Gerrit-Owner: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 22 May 2019 16:58:21 +0000 Gerrit-HasComments: Yes
