Sudhanshu Arora has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 )
Change subject: acid: Filter unwanted files based on ACID state. ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/13334/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/13334/8/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@571 PS8, Line 571: to > nit: camel case Done http://gerrit.cloudera.org:8080/#/c/13334/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/13334/8/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@549 PS8, Line 549: > keeping this as a Predicate<String> makes sense to me, since this is common Done http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java@151 PS12, Line 151: statementGroup.substring(1) > DELTA_PATTERN allows strings like 'delta_1_2_asdf', i.e. we have the traili delta_1_2_asdf will not match the pattern. delta_1_2/_asdf will match. However group3 in this case will be null so we will not try to get a long value. -- To view, visit http://gerrit.cloudera.org:8080/13334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0aeb36e10c827ead59ed7f67e731199394fe8e Gerrit-Change-Number: 13334 Gerrit-PatchSet: 12 Gerrit-Owner: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 17:30:25 +0000 Gerrit-HasComments: Yes
