Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 )
Change subject: acid: Filter unwanted files based on ACID state. ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java@48 PS12, Line 48: private static final Pattern BASE_PATTERN = Pattern.compile("base_(\\d+)(/.*)?"); : private static final Pattern DELTA_PATTERN = : Pattern.compile("delta_(\\d+)_(\\d+)(_\\d+)?(/.*)?"); > nit: maybe you could use "name-capturing groups" in the regex to make it mo Done. Also changed the capturing a bit so we only capture the numeric portion of the optional statement ID http://gerrit.cloudera.org:8080/#/c/13334/12/fe/src/main/java/org/apache/impala/util/AcidUtils.java@170 PS12, Line 170: >= > Shouldn't this be '=='? Can it happen that baseNum is greater than max base Done -- To view, visit http://gerrit.cloudera.org:8080/13334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf0aeb36e10c827ead59ed7f67e731199394fe8e Gerrit-Change-Number: 13334 Gerrit-PatchSet: 12 Gerrit-Owner: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 18:44:58 +0000 Gerrit-HasComments: Yes
