Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 )
Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/13372/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13372/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@21 PS4, Line 21: import static org.apache.impala.catalog.events.MetastoreEventProcessorConfig.ADD_THRIFT_OBJECTS; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13372/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@22 PS4, Line 22: import static org.apache.impala.catalog.events.MetastoreEventProcessorConfig.ALTER_NOTIFICATIONS_BASIC; line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/13372/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@23 PS4, Line 23: import static org.apache.impala.catalog.events.MetastoreEventProcessorConfig.METASTORE_PARAMETER_EXCLUDE_PATTERNS; line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/13372/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@24 PS4, Line 24: import static org.apache.impala.catalog.events.MetastoreEventProcessorConfig.FIRE_EVENTS_FOR_DML; line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35b3dd93f4a90c103a402349e8b9cd36db39a259 Gerrit-Change-Number: 13372 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 23 May 2019 19:07:32 +0000 Gerrit-HasComments: Yes