Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 )
Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 ...................................................................... Patch Set 5: (4 comments) Just a few nits remaining. http://gerrit.cloudera.org:8080/#/c/13372/3/fe/src/main/java/org/apache/impala/catalog/events/ConfigValidator.java File fe/src/main/java/org/apache/impala/catalog/events/ConfigValidator.java: http://gerrit.cloudera.org:8080/#/c/13372/3/fe/src/main/java/org/apache/impala/catalog/events/ConfigValidator.java@37 PS3, Line 37: */ > I thought any sub-class in a interface is public by default. Still added it oh, you're probably right. I always forget that. http://gerrit.cloudera.org:8080/#/c/13372/5/fe/src/main/java/org/apache/impala/catalog/events/ConfigValidator.java File fe/src/main/java/org/apache/impala/catalog/events/ConfigValidator.java: http://gerrit.cloudera.org:8080/#/c/13372/5/fe/src/main/java/org/apache/impala/catalog/events/ConfigValidator.java@26 PS5, Line 26: class capture still a typo here: "to capture"? http://gerrit.cloudera.org:8080/#/c/13372/5/fe/src/main/java/org/apache/impala/catalog/events/ConfigValidator.java@67 PS5, Line 67: return reason_; Adding a precondition.checkState() here is also useful because it ensures that no one is calling getReason() without checking isValid() first http://gerrit.cloudera.org:8080/#/c/13372/5/fe/src/main/java/org/apache/impala/catalog/events/DefaultConfigValidator.java File fe/src/main/java/org/apache/impala/catalog/events/DefaultConfigValidator.java: http://gerrit.cloudera.org:8080/#/c/13372/5/fe/src/main/java/org/apache/impala/catalog/events/DefaultConfigValidator.java@48 PS5, Line 48: boolean result = expectedValue_.equalsIgnoreCase(configValue); since this variable is only used once, just inline the expression in the if()? -- To view, visit http://gerrit.cloudera.org:8080/13372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35b3dd93f4a90c103a402349e8b9cd36db39a259 Gerrit-Change-Number: 13372 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2019 20:29:06 +0000 Gerrit-HasComments: Yes
