Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 )
Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13372/5/fe/src/main/java/org/apache/impala/catalog/events/DefaultConfigValidator.java File fe/src/main/java/org/apache/impala/catalog/events/DefaultConfigValidator.java: http://gerrit.cloudera.org:8080/#/c/13372/5/fe/src/main/java/org/apache/impala/catalog/events/DefaultConfigValidator.java@48 PS5, Line 48: if (expectedValue_.equalsIgnoreCase(configValue)) { > since this variable is only used once, just inline the expression in the if Done -- To view, visit http://gerrit.cloudera.org:8080/13372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35b3dd93f4a90c103a402349e8b9cd36db39a259 Gerrit-Change-Number: 13372 Gerrit-PatchSet: 8 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2019 21:28:22 +0000 Gerrit-HasComments: Yes
