Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13319 )
Change subject: IMPALA-8503: allow the Hive Metastore to start with kudu-hive plugin ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13319/2/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13319/2/bin/bootstrap_toolchain.py@424 PS2, Line 424: addtional_file = None So as written this isn't going to work for non-cdh supported platforms (eg. ubuntu14). That's because 'kudu' won't be added to the list of cdh components on such platforms (see line 573). On those platforms, we download the platform-specific Kudu bits from the toolchain instead (see line 542), but we'll still want to download these jars from cdh_components because the toolchain doesn't produce the jars. How about, we have two kudu components - call the Java one just 'kudu' and always add it to cdh_components on line 563. Then have another one, call it 'kudu-c++' or similar, which gets adds to cdh_components on line 573, and then modify the 'if' on line 425 to check for that component name. -- To view, visit http://gerrit.cloudera.org:8080/13319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bd1488ced51840ec986d29ed371e26168abcc76 Gerrit-Change-Number: 13319 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 31 May 2019 20:29:37 +0000 Gerrit-HasComments: Yes
