Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13319 )
Change subject: IMPALA-8503: allow the Hive Metastore to start with kudu-hive plugin ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13319/3/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13319/3/bin/bootstrap_toolchain.py@571 PS3, Line 571: cdh_components += [Package("kudu-java")] Could you add a comment here like: Always download Kudu's jars regardless of USE_CDH_KUDU since they aren't platform dependent and aren't packaged by the toolchain. http://gerrit.cloudera.org:8080/#/c/13319/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/13319/3/bin/impala-config.sh@670 PS3, Line 670: export IMPALA_KUDU_JAVA_VERSION=${IMPALA_KUDU_VERSION-"1.10.0-cdh6.x-SNAPSHOT"} I don't think this logic works - you'll get a weird result in the case that USE_CDH_KUDU=false, since your java version will be getting set to the random git hash above. Could you just modify the existing env var KUDU_JAVA_VERSION on line 174 to have IMPALA_ as a prefix? (and fix any place that var is used, I think the only place is impala-parent/pom.xml) Also, please do a full build with USE_CDH_KUDU=false set in order to confirm that it works (you don't have to actually do this on a non-CDH platform, just set the env variable, and also please delete your toolchain directory before doing it and verify that the contents of cdh_components/kudu... are as expected, i.e. the kudu-hive jar and not the binaries) -- To view, visit http://gerrit.cloudera.org:8080/13319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bd1488ced51840ec986d29ed371e26168abcc76 Gerrit-Change-Number: 13319 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 31 May 2019 23:03:11 +0000 Gerrit-HasComments: Yes
