Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13319 )
Change subject: IMPALA-8503: allow the Hive Metastore to start with kudu-hive plugin ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13319/3/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13319/3/bin/bootstrap_toolchain.py@571 PS3, Line 571: # Always download Kudu's jars regardless of USE_CDH_KUDU since they > Could you add a comment here like: Done http://gerrit.cloudera.org:8080/#/c/13319/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/13319/3/bin/impala-config.sh@670 PS3, Line 670: > I don't think this logic works - you'll get a weird result in the case that Thanks for the suggestion, tested with set USE_CDH_KUDU=false, and the cdh_components/kudu... dir contains expected jars. -- To view, visit http://gerrit.cloudera.org:8080/13319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bd1488ced51840ec986d29ed371e26168abcc76 Gerrit-Change-Number: 13319 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Sat, 01 Jun 2019 05:48:47 +0000 Gerrit-HasComments: Yes