Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 )
Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load ...................................................................... Patch Set 1: (2 comments) I think the solution makes sense, although I don't have a particularly deep understanding so I'd like more eyes on it. Just a couple of questions about testing and for my understanding. http://gerrit.cloudera.org:8080/#/c/13557/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13557/1//COMMIT_MSG@17 PS1, Line 17: This re-enables some tests that were previously disabled for Were you able to run the end-to-end tests with the local catalog enabled? I had disabled local catalog in precommit because of other flakiness, so just want to make sure it works as expected. http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/13557/1/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@40 PS1, Line 40: * Represents a table with incomplete metadata. The metadata may be incomplete because Trying to understand - does this IncompleteTable implementation get used in LocalCatalog in some cases? Or is it only for CatalogServiceCatalog and ImpaladCatalog? The code paths are a little intermingled (at least when I'm trying to get a handle on things). If it's only used in some catalog implementations, might be good to mention briefly in the class comment. -- To view, visit http://gerrit.cloudera.org:8080/13557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia85d6b10669866dcc9f2bf7385a4775e483dd6b0 Gerrit-Change-Number: 13557 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2019 16:09:49 +0000 Gerrit-HasComments: Yes
